This repository has been archived by the owner on Nov 4, 2023. It is now read-only.
Allow to suppress charging state notification #283
+108
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is your plan to add these settings somewhere in Since some devices only have a single-color LED, I'd recommend adding something to the device config parser in another PR. This additional metadata could tell the system if it should even try to use multi-color LEDs. Then users don't need to choose if they want their LED on all the time during charging. |
mariogrip
reviewed
Mar 3, 2020
wdehoog
force-pushed
the
xenial_-_configure-led-notification
branch
from
966eff2
to
4701cbd
Compare
… to test. The combination Loader/Component results in another instance in memory which also starts to control the led making testing impossible.
|
Sorry for the wait... Unfortunately, this PR now conflicts on fake_gsettings... Could you please resolve this conflict (you may want to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people don't like charging state indication and some devices might only have one led blink pattern. These changes allow to disable showing them (dconf write
/com/lomiri/ledindication/charging-state-visible false).See ubports/ubuntu-touch#1377
(edited to show new settings namespace)